Repository navigation
Commit 1b76339
committed
testsuite: fix the two macOS cells the 3.5.0 fleet run flagged
Running the 3.5.0 suite against this branch across the fleet left four
not-OK cells, all macOS, identical on both backport branches. Both causes
are here, not in the code under test.
t_symlink_secure.c lives at the tree ROOT, so fleettest's overlay -- which
replaces runtests.py and testsuite/ -- does not update it. This branch was
still running a version predating the HAVE_MKNODAT guard, so on a platform
without mknodat() (macOS 10.13) it asserted a confinement the build
deliberately compiles out and reported "basename symlink was followed ->
module escape". Alarming and wrong: there is no escape, the helper was just
older than the test driving it. Taking the current helper makes it skip
there, which is what the fleet config already expects for that target.
partial-protected-regular-retry-policy exercises the receiver's EACCES
recovery path. That path is 3.5.0-only -- the chmod-on-denied-open work is
not backported, which is also why partial_nowrite is already excluded here --
so the test cannot reach what it checks and reports "inconclusive" rather
than skipping. Excluded for the same reason as its sibling.
Verified on the x86-64 macOS box: the policy test is excluded and
symlink-mknod-fakesuper-symlink-race now skips, overall result 0. A 3.5.0
build on the same hardware passes both, so neither is a platform limitation.1 parent 75e30b2 commit 1b76339
2 files changed
Lines changed: 17 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
88 | 88 | | |
89 | 89 | | |
90 | 90 | | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
91 | 101 | | |
92 | 102 | | |
93 | 103 | | |
| |||
131 | 141 | | |
132 | 142 | | |
133 | 143 | | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
134 | 149 | | |
135 | 150 | | |
136 | 151 | | |
137 | 152 | | |
138 | 153 | | |
| 154 | + | |
139 | 155 | | |
140 | 156 | | |
141 | 157 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| 27 | + | |
27 | 28 | | |
28 | 29 | | |
29 | 30 | | |
| |||
0 commit comments