Skip to content

Generation of webpack as part of npm publishing step #93

Description

@abhayks1
  • Pre commit hook is there to generate webpack which generates distribution in dist directory. It should be removed.
  • Builds should not be part of the repository, but instead be done in the npm prepack script so that they are built when packaging or publishing.
  • Also, a library that is published usually goes into a lib directory, not a dist directory. But that is something we also don’t do everywhere, yet. And any build artifacts should be listed in .gitignore.
  • It should not be a pre-commit hook.
  • Don’t add tests to the distributed files.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions