FileRename missing OldUri

[tzwaan]

According to the LSP spec, the FileRename object should have an oldUri and newUri property, but the csharp record only seems to have a single Uri.

https://microsoft.github.io/language-server-protocol/specifications/lsp/3.18/specification/#fileRename

[mason-chase]

Can you show example of where do you observe this in OmniSharp?

[JoeRobich]

@tzwaan Looking at the RenameFile model, I am seeing OldUri and NewUri.

csharp-language-server-protocol/src/Protocol/Models/RenameFile.cs

Lines 15 to 23 in e0f5910

	/// <summary>
	/// The old (existing) location.
	/// </summary>
	public DocumentUri OldUri { get; init; } = null!;
	/// <summary>
	/// The new location.
	/// </summary>
	public DocumentUri NewUri { get; init; } = null!;

[tzwaan]

That's the RenameFile model, which is used when sending a workspace edit from the server to the client: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.18/specification/#renameFile

Not the FileRename model, which is used to send a notification from the client to the server that a file has been renamed: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.18/specification/#fileRename

Digging though the repo, it looks like this issue has already been fixed in 2023, but was never pushed in a release. The commit is from october 22, 2023 while the latest release is from september 21, 2023.
eb06422