-
Notifications
You must be signed in to change notification settings - Fork 9
#4238 reschedule meetings #4257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
c647b77
first commit as a midpoint
glickgNU 08f5e8d
added all changes. Perhaps need to change slack message
glickgNU 03bec24
the rescheduling and alert should work
glickgNU 4811ebb
readded underline clarification
glickgNU 0df0867
added suggestions + fixed days shown
glickgNU 5528994
removed console.logs
glickgNU 322f5ce
removed redundant previousDate
glickgNU 53b521c
fixed time issues
glickgNU bf400f9
Merge branch 'develop' into #4238-reschedule-meetings
glickgNU 49f73c1
Remove unused isSameDay import from calendar.services.ts
glickgNU b1d26af
Fix formatting in slack.utils
glickgNU 021c93f
scheduled/reschedule for one message
glickgNU 835d610
linter and prettier fix
glickgNU ca1df2c
removed redundant null check in calendar.services.ts
glickgNU f292f3f
Refactor event status check to use enum in calendar.services.ts
glickgNU a5d922d
use EventStatus enum in EventAvailabilityPage + removed underline rep…
glickgNU 2a978f7
Refactor ScheduleEventModal for cleaner logic
glickgNU ca350ae
Use EventStatus enum rather than strings
glickgNU fa14b55
Remove users query invalidation from hooks
glickgNU c4bf6b3
Simplify button rendering logic in ScheduleEventModal
glickgNU abd8d01
Fix optional chaining for event status check
glickgNU File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -473,9 +473,13 @@ export const sendEventConfirmationToThread = async (threads: SlackMessageThread[ | |
| } | ||
| }; | ||
|
|
||
| export const sendEventScheduledSlackNotif = async (threads: SlackMessageThread[], event: Event) => { | ||
| export const sendEventScheduledSlackNotif = async ( | ||
| threads: SlackMessageThread[], | ||
| event: Event, | ||
| beingRescheduled: boolean = false | ||
| ) => { | ||
| if (process.env.NODE_ENV !== 'production' && !DEV_TESTING_OVERRIDE) return; // don't send msgs unless in prod | ||
|
|
||
| const scheduledOrRescheduled = beingRescheduled ? 'rescheduled' : 'scheduled'; | ||
| // Get work package names | ||
| const wpNames = event.workPackages.map((wp) => wp.wbsElement.name).join(', '); | ||
| const drName = event.title + (wpNames ? ` (${wpNames})` : ''); | ||
|
|
@@ -507,7 +511,10 @@ export const sendEventScheduledSlackNotif = async (threads: SlackMessageThread[] | |
| const validSlackIds = resolvedSlackIds.filter((id): id is string => !!id); | ||
| const mentionPrefix = buildSlackMentionPrefix(SlackMentionType.USER, validSlackIds); | ||
|
|
||
| const msg = `:spiral_calendar_pad: ${event.title} for *${drName}* has been scheduled for *${drTime}* ${location} by ${drSubmitter}`; | ||
| const msg = | ||
| `:spiral_calendar_pad: ${event.title} for *${drName}* has been ` + | ||
| scheduledOrRescheduled + | ||
| ` for *${drTime}* ${location} by ${drSubmitter}`; | ||
| const docLink = event.questionDocumentLink ? `<${event.questionDocumentLink}|Doc Link>` : ''; | ||
| const threadMsg = `${mentionPrefix}This event has been Scheduled! \n` + docLink; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. On line 519 can you update threadMsg to say scheduled/rescheduled depending on which it is |
||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.