From ef6e81aeda9d767e84ce23f8de0b9cbfb70bad58 Mon Sep 17 00:00:00 2001 From: Jonas Berlin Date: Thu, 29 Nov 2018 12:07:05 +0200 Subject: [PATCH] FieldMatcher: Fix access to private fields (fixes #1) Also report any field access failure instead of silently ignoring. --- src/main/java/com/nitorcreations/matchers/FieldMatcher.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/main/java/com/nitorcreations/matchers/FieldMatcher.java b/src/main/java/com/nitorcreations/matchers/FieldMatcher.java index acfbad6..1979247 100644 --- a/src/main/java/com/nitorcreations/matchers/FieldMatcher.java +++ b/src/main/java/com/nitorcreations/matchers/FieldMatcher.java @@ -33,9 +33,10 @@ protected boolean matchesSafely(T item, Description mismatchDescription) { if (valueMatcher == null) return true; try { + field.setAccessible(true); return valueMatcher.matches(field.get(item)); } catch (IllegalAccessException e) { - return false; + throw new RuntimeException("Failed to access field " + fieldName + " in " + item.getClass().getName(), e); } }