Skip to content

Commit dba03a6

Browse files
authored
Merge pull request #417 from Modalities/hotfix_benchmarking
Hotfixes for Slurm benchmarking scripts
2 parents 060154c + 4ff17a2 commit dba03a6

2 files changed

Lines changed: 5 additions & 4 deletions

File tree

‎tutorials/scaling_up/scripts/hpc/leonardo/job.sbatch‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,8 @@ echo "START TIME: $(date)"
4747

4848
# Step 1: Filter configs
4949
modalities benchmark list_remaining_runs \
50-
--exp_root "$EXPERIMENT_ROOT/$NUM_RANKS" \
50+
--exp_root "$EXPERIMENT_ROOT" \
51+
--world_size "$NUM_RANKS" \
5152
--file_list_path "$CONFIG_LIST_FILE" \
5253
--expected_steps "$EXPECTED_STEPS" \
5354
--skip_exception_types "OutOfMemoryError,ValueError"
@@ -84,4 +85,4 @@ echo "END TIME: $(date)"
8485

8586
# Clean up
8687
rm "$CONFIG_LIST_FILE"
87-
echo "=== FINISHED ==="
88+
echo "=== FINISHED ==="

‎tutorials/scaling_up/scripts/hpc/leonardo/submit_sweep.sh‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,9 @@ for ws in $worldsizes; do
4242
--qos=$QOS \
4343
--nodes=$NODES \
4444
--time=$TIME_LIMIT \
45-
--export=EXPERIMENT_ROOT=$EXPERIMENT_ROOT,EXPECTED_STEPS=$EXPECTED_STEPS \
45+
--export=EXPERIMENT_ROOT=ALL,$EXPERIMENT_ROOT,EXPECTED_STEPS=$EXPECTED_STEPS \
4646
job.sbatch
4747
done
4848

4949
rm "$CONFIG_LIST_FILE"
50-
echo "All jobs submitted."
50+
echo "All jobs submitted."

0 commit comments

Comments
 (0)