Fix failing CI tests#140
Merged
Merged
Conversation
- requirements_loose.txt: add test:tolerate_version comment to pandas<3 - test_cluster_missingval: call private _determine_missingval_test_level and assert its return value (function was made private and no longer sets global) - test_diff_analysis: replace removed backgrounds[] list with ion2background dict - test_intensity_summarization: update asymmetric_conditions expectation to log2(100) — implementation filters to ions present in both conditions - test_residual_decorrelation: import pytest and skip when sandbox reference file is absent (not available in CI) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
# test: tolerate_versioncomment topandas<3inrequirements_loose.txtso the requirements test accepts the intentional upper-bound pin_determine_missingval_test_level(renamed in an earlier PR) and assert its return value instead of the module global (global mutation was also removed)condbg.backgrounds[idx](old list API) withcondbg.ion2background[ions[idx]](current dict API) in 2 teststest_asymmetric_conditionsexpectation — the implementation filters groups to ions present in both conditions, so Y4 (absent from c2) is excluded and c1 sums tolog2(100)notlog2(150)import pytestand apytest.skipguard in_load_reference_modulewhen the local sandbox file is not available (file only exists in certain dev environments, not CI)Test plan
🤖 Generated with Claude Code