From 84026ac70bc525fdd972ac971d294778d6350207 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Sun, 8 Jan 2023 21:50:55 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- .../phenio/phenio_transform.py | 21 ++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/kg_phenio/transform_utils/phenio/phenio_transform.py b/kg_phenio/transform_utils/phenio/phenio_transform.py index 7c24041..39ef55d 100644 --- a/kg_phenio/transform_utils/phenio/phenio_transform.py +++ b/kg_phenio/transform_utils/phenio/phenio_transform.py @@ -63,7 +63,26 @@ def parse(self, name: str, data_file: str, source: str) -> None: if os.path.exists(data_file + ".tar.gz"): print(f"Decompressing {data_file}") with tarfile.open(data_file) as compfile: - compfile.extractall(self.input_base_dir) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner) + + + safe_extract(compfile, self.input_base_dir) else: print(f"Found ontology at {data_file}")