JBR-8651 Pycharm Crashing after lock/sleep: SIGABRT at # C [libsystem_kernel.dylib+0x9388] __pthread_kill / __displaycb_handle_block_invoke

Minimal changes for JBR-21: added @try/&@catch(nsexception) in ThreadUtilities.processQueuedCallbacks() to handle any native or java exception and avoid crashing the main run loop

Author: bourgesl

src/java.desktop/macosx/native/libawt_lwawt/awt/CGraphicsEnv.m

@@ -116,6 +116,7 @@
 (CGDirectDisplayID displayId, CGDisplayChangeSummaryFlags flags, void *userInfo)
 {
 AWT_ASSERT_APPKIT_THREAD;
+JNIEnv *env = [ThreadUtilities getJNIEnv];
 JNI_COCOA_ENTER(env);
 
     if (TRACE_DISPLAY_CALLBACKS) {
@@ -152,7 +153,6 @@
                                                      block:^()
         {
             @try {
-                JNIEnv *env = [ThreadUtilities getJNIEnv];
                 jobject graphicsEnv = (*env)->NewLocalRef(env, cgeRef);
                 if (graphicsEnv == NULL) return; // ref already GC'd
                 DECLARE_CLASS(jc_CGraphicsEnvironment, "sun/awt/CGraphicsEnvironment");
@@ -173,7 +173,6 @@
 
     // braces to reduce variable scope
     {
-        JNIEnv *env = [ThreadUtilities getJNIEnv];
         jobject graphicsEnv = (*env)->NewLocalRef(env, cgeRef);
         if (graphicsEnv == NULL) return; // ref already GC'd
         DECLARE_CLASS(jc_CGraphicsEnvironment, "sun/awt/CGraphicsEnvironment");

src/java.desktop/macosx/native/libosxapp/ThreadUtilities.m

@@ -254,8 +254,11 @@ + (void)setAppkitThreadGroup:(jobject)group {
  * Note : if waiting cross-thread, possibly the stack allocated copy is accessible ?
  */
 + (void)invokeBlockCopy:(void (^)(void))blockCopy {
-    blockCopy();
-    Block_release(blockCopy);
+    @try {
+        blockCopy();
+    } @finally {
+        Block_release(blockCopy);
+    }
 }
 
 + (NSString*)getCaller:(NSString*)prefixSymbol {
@@ -780,9 +783,18 @@ - (void)processQueuedCallbacks {
     const NSUInteger count = [self.queue count];
     if (count != 0) {
         for (NSUInteger i = 0; i < count; i++) {
-            void (^blockCopy)(void) = (void (^)())[self.queue objectAtIndex: i];
-            // invoke callback:
-            [ThreadUtilities invokeBlockCopy:blockCopy];
+            NSAutoreleasePool *pool = [[NSAutoreleasePool alloc] init];
+            @try {
+                void (^blockCopy)(void) = (void (^)())[self.queue objectAtIndex: i];
+                // invoke callback:
+                [ThreadUtilities invokeBlockCopy:blockCopy];
+            } @catch (NSException *exception) {
+                // handle any exception to avoid crashing the main run loop:
+                NSLog(@"Apple AWT Cocoa Exception: %@", [exception description]);
+                NSLog(@"Apple AWT Cocoa Exception callstack: %@", [exception callStackSymbols]);
+            } @finally {
+                [pool drain];
+            }
         }
         // reset queue anyway:
         [self reset];