Skip to content

test#6062

Draft
victorvhs017 wants to merge 774 commits intofeat/auth-revampfrom
main
Draft

test#6062
victorvhs017 wants to merge 774 commits intofeat/auth-revampfrom
main

Conversation

@victorvhs017
Copy link
Copy Markdown
Contributor

Context

Screenshots

Steps to verify the change

Type

  • Fix
  • Feature
  • Improvement
  • Breaking
  • Docs
  • Chore

Checklist

  • Title follows the conventional commit format: type(scope): short description (scope is optional, e.g., fix: prevent crash on sync or fix(api): handle null response).
  • Tested locally
  • Updated docs (if needed)
  • Updated CLAUDE.md files (if needed)
  • Read the contributing guide

@maidul98
Copy link
Copy Markdown
Collaborator

maidul98 commented Apr 17, 2026

Snyk checks have failed. 1 issues have been found so far.

Status Scan Engine Critical High Medium Low Total (1)
Open Source Security 1 0 0 0 1 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@gitguardian
Copy link
Copy Markdown

gitguardian Bot commented Apr 18, 2026

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

bernie-g and others added 8 commits April 30, 2026 09:43
Top Actors card now sizes to its content (1-10 rows) instead of stretching to fill the right column, and Resources by Type drops the per-row integration icon for a cleaner legend.
… verification

- Introduced a new column `enableSsl` in the IdentityKubernetesAuth table to control TLS verification.
- Updated schemas and API documentation to reflect the new `enableSsl` parameter.
- Enhanced validation logic to require a CA certificate when SSL verification is enabled.
- Modified frontend forms to include a toggle for enabling SSL verification.
…r TLS verification

- Added a new migration to introduce the `verifyTlsCertificate` column in the IdentityKubernetesAuth table.
- Updated schemas, API documentation, and frontend forms to reflect the change from `enableSsl` to `verifyTlsCertificate`.
- Enhanced validation logic to require a CA certificate when TLS verification is enabled.
- Adjusted related service and validation logic to utilize the new `verifyTlsCertificate` parameter.
- Updated API documentation to clarify the behavior of `caCert` and `verifyTlsCertificate`.
- Added validation to prevent disabling TLS verification when a CA certificate is provided.
- Adjusted service logic to enforce the new validation rules.
- Modified frontend forms to reflect the updated verification requirements and improve user experience.
Matches the behavior of the View Failed Rotations button so empty cards consistently render badge-only with no disabled button stub.
…ult-for-kubernetes-auth

fix(kubernetes-auth): configurable TLS verification for identity Kubernetes auth
sheensantoscapadngan and others added 14 commits May 1, 2026 03:54
The pie chart was switched to render resourceCount only, so accountCount was no longer surfaced anywhere on the frontend. Remove the dead aggregation along with its DAL helper and route schema field instead of patching the merge logic.
…alues

- Introduced a new utility function to resolve effective TLS certificate verification based on CA certificate presence.
- Updated service logic to utilize the new function for determining `rejectUnauthorized` settings.
- Adjusted frontend form to set `verifyTlsCertificate` default to false, enhancing user experience and aligning with backend logic.
* fix(pam): default access duration to policy max in request modal

The Request Account Access modal hardcoded the access duration to "4h",
which fails when the matching policy's max is smaller (e.g., "10m").
Fetch the matched policy's accessDuration.max via /check-policy-match,
default the field to it, and reject above-max values client-side.

Also adds .orderBy("id", "asc") to findByProjectId so matchPolicy is
deterministic across the modal-open and submit calls. This is a behavior
change for cert-request matching too (overlapping cert policies now
resolve to the lowest-id policy instead of arbitrary order).

* fix(pam): reject access duration below 30s in request modal

The backend already enforces a 30s floor via DurationSchema, but the
client only checked max — so values like "10s" slipped past the modal
and surfaced as a generic toast on submit. Mirror the floor client-side
so it shows as an inline field error.

* refactor(pam): extract check-policy-match response schemas

Move the inline response schemas in approval-policy-routers/index.ts
into named exports that follow the existing Base* / PamAccess* pattern
used by sibling schemas.
…ll-instead-of-encrypt-in-kubernetes-auth

fix(k8s-auth): align TLS verification with CA presence and empty CA storage
…-template

chore: update bug report issue template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.