From 014bfbd2f443c22071175dce0acc98ea924a24a0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?St=C3=A5le=20Pedersen?= Date: Tue, 7 Apr 2026 12:24:31 +0200 Subject: [PATCH] Avoid redundant shSync in ExitCode by reusing exit code from Sh.postRun --- .../main/java/io/hyperfoil/tools/qdup/cmd/impl/ExitCode.java | 2 +- .../src/main/java/io/hyperfoil/tools/qdup/cmd/impl/Sh.java | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/qDup-core/src/main/java/io/hyperfoil/tools/qdup/cmd/impl/ExitCode.java b/qDup-core/src/main/java/io/hyperfoil/tools/qdup/cmd/impl/ExitCode.java index 623555cb..1d517acc 100644 --- a/qDup-core/src/main/java/io/hyperfoil/tools/qdup/cmd/impl/ExitCode.java +++ b/qDup-core/src/main/java/io/hyperfoil/tools/qdup/cmd/impl/ExitCode.java @@ -14,7 +14,7 @@ */ public class ExitCode extends Cmd { - private static final String EXIT_CODE_KEY = "qdupExitCode"; + static final String EXIT_CODE_KEY = "qdupExitCode"; private static final String DEFAULT_EXIT_CODE = "-1"; private String expected; diff --git a/qDup-core/src/main/java/io/hyperfoil/tools/qdup/cmd/impl/Sh.java b/qDup-core/src/main/java/io/hyperfoil/tools/qdup/cmd/impl/Sh.java index 08aa434e..2db78e43 100644 --- a/qDup-core/src/main/java/io/hyperfoil/tools/qdup/cmd/impl/Sh.java +++ b/qDup-core/src/main/java/io/hyperfoil/tools/qdup/cmd/impl/Sh.java @@ -208,6 +208,8 @@ public void postRun(String output,Context context){ context.abort(false); } else if (context.getShell().isReady() && !context.isAborted()) { context.setCwd(pwd); + // Store exit code for ExitCode command to find without a separate shSync + with(ExitCode.EXIT_CODE_KEY, response); if(response.matches("\\d+")){ try { context.getCommandTimer().getData().set("exit_code", Integer.parseInt(response));