Skip to content

fix(webhooks): Prevent SSRF in webhooks and webhook tests #7550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matthewelwell wants to merge 8 commits into
base: main
Choose a base branch
from
Open

fix(webhooks): Prevent SSRF in webhooks and webhook tests #7550

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c77dde9
Hide exception details from webhook test response
matthewelwell May 20, 2026
fa80188
Update unit test
matthewelwell May 20, 2026
0a05e84
Conceal all non-200 response bodies
matthewelwell May 20, 2026
b3bdf88
Fix tests
matthewelwell May 20, 2026
d31d339
Restrict to valid public URLs
matthewelwell May 20, 2026
36a5868
Fix test
matthewelwell May 20, 2026
f8cc8b7
Prevent webhook redirects
matthewelwell May 21, 2026
626db5c
Use getaddrinfo to catch private IPv6 addresses in SSRF validator
matthewelwell May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions api/webhooks/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,11 @@ def test(self, request: Request) -> Response:
},
status=status.HTTP_200_OK,
)
except requests.exceptions.RequestException as e:
except requests.exceptions.RequestException:
return Response(
{
"detail": "Could not connect to webhook URL",
"body": str(e),
"body": "Please check the URL, and ensure it is valid and accessible from the server.",
},
status=status.HTTP_400_BAD_REQUEST,
)
Loading