fix: Extend truename protection to offline players - #1208
Merged
Robotgiggle merged 3 commits intoJul 26, 2026
Conversation
|
During deserialization, I suggest checking if it exists first. That way, previously saved iotas are not broken. |
|
It fits nicely with the |
Contributor
Author
|
Thanks @c-Caelum :D |
Contributor
Author
|
I forgot to specify this in the comment as well: existing Entity Iotas wil nowl not turn into Garbage, I tested it :D |
Olfi01
force-pushed
the
issue/1062-fix-truename-protection
branch
from
July 25, 2026 15:55
a2dff83 to
90db720
Compare
Robotgiggle
enabled auto-merge
July 26, 2026 02:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1062
Even though I was only able to verify a possible exploit using another bug (list evaluation of stale iotas), it is still possible that an addon developer passes non-verified iotas to the
getTrueNameFromDatummethod.To protect offline players as well, I added a boolean to the EntityIota like @slava110 suggested.
This change will make all previously saved entity iotas turn into Garbage.Fixed