Skip to content

Can we remove the webhook repository? #969

Description

@dennisvang

The index defines a WebhookRepository, but there is no way to create any webhooks, so the repository is never actually populated. As a result, any queries will always return empty.

Should we remove the WebhookRepository and related usages, and the @Document annotation on Webhook?

This was introduced as part of 38a5fbd (back in 2020). However, no rationale was provided, so it is not clear whether the save functionality was not implemented yet, or whether it was some legacy thing that can be removed. Actually the whole webhook functionality is undocumented...

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    devRelated to development, e.g. code style, refactoring, github workflows, etc.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions