Summary
Current CI tests use an in-memory triple store instead of an external triple store.
As a result, the tests are not representative of typical production deployments.
Details
The default repository.type is 1 (in-memory), and this is not overridden in the test config:
|
# valid repository type options {1 = inMemoryStore, 2 = NativeStore, 3 = AllegroGraph, 4 = graphDB, 5 = blazegraph} |
|
repository: |
|
type: ${FDP_TRIPLE_STORE_TYPE:1} |
Moreover, there is an explicit RepositoryTestConfig that enforces an in-memory store:
|
public Repository repository() throws RepositoryException, RDFParseException { |
|
return new SailRepository(new MemoryStore()); |
|
} |
However, I'm not sure yet if this is actually used...
Finally, the maven-verify CI workflow does not set up an external repository:
|
uses: FAIRDataTeam/github-workflows/.github/workflows/maven-verify.yml@v2 |
Summary
Current CI tests use an in-memory triple store instead of an external triple store.
As a result, the tests are not representative of typical production deployments.
Details
The default
repository.typeis1(in-memory), and this is not overridden in the test config:FAIRDataPoint/src/main/resources/application.yml
Lines 43 to 45 in 67ec393
Moreover, there is an explicit
RepositoryTestConfigthat enforces an in-memory store:FAIRDataPoint/src/test/java/org/fairdatateam/fairdatapoint/config/RepositoryTestConfig.java
Lines 42 to 44 in 67ec393
However, I'm not sure yet if this is actually used...
Finally, the maven-verify CI workflow does not set up an external repository:
FAIRDataPoint/.github/workflows/maven-verify.yml
Line 31 in 67ec393