Skip to content

CI tests do not use external triple store #903

Description

@dennisvang

Summary

Current CI tests use an in-memory triple store instead of an external triple store.

As a result, the tests are not representative of typical production deployments.

Details

The default repository.type is 1 (in-memory), and this is not overridden in the test config:

# valid repository type options {1 = inMemoryStore, 2 = NativeStore, 3 = AllegroGraph, 4 = graphDB, 5 = blazegraph}
repository:
type: ${FDP_TRIPLE_STORE_TYPE:1}

Moreover, there is an explicit RepositoryTestConfig that enforces an in-memory store:

public Repository repository() throws RepositoryException, RDFParseException {
return new SailRepository(new MemoryStore());
}

However, I'm not sure yet if this is actually used...

Finally, the maven-verify CI workflow does not set up an external repository:

uses: FAIRDataTeam/github-workflows/.github/workflows/maven-verify.yml@v2

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    devRelated to development, e.g. code style, refactoring, github workflows, etc.improvementExisting functionality that can be improvedtestsRelated to tests

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions