Commit 348db70
chore: upgrade common lib and set release v3.18.1 (#277)
* Fix LocalStorageAssignmentShim reading localStorage["undefined"] during construction
Class field initializers for `size` and `[Symbol.toStringTag]` called
`this.getCache()` before the constructor body assigned `this.localStorageKey`,
causing `localStorage.getItem("undefined")`. If that key held non-JSON data,
`JSON.parse` threw and the SDK failed to initialize.
Convert both to getters so they no longer eagerly read localStorage during
construction. This also fixes a secondary bug where `size` was a stale
snapshot that never updated after mutations.
FFESUPPORT-610
Made-with: Cursor
* chore: bump version to 3.18.1 and use jest^29.x range, noting node 23 compat.
* upgrade js-common
* chore: commit latent docs changes
---------
Co-authored-by: bertilhatt <bertil.hatt@datadoghq.com>1 parent 19405ce commit 348db70
File tree
4 files changed
+10
-11
lines changed- docs
4 files changed
+10
-11
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
13 | 13 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
8 | | - | |
9 | 7 | | |
10 | 8 | | |
11 | 9 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
37 | | - | |
| 37 | + | |
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
| |||
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
62 | | - | |
| 62 | + | |
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
| 66 | + | |
66 | 67 | | |
67 | 68 | | |
68 | 69 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
402 | 402 | | |
403 | 403 | | |
404 | 404 | | |
405 | | - | |
406 | | - | |
407 | | - | |
408 | | - | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
409 | 409 | | |
410 | 410 | | |
411 | 411 | | |
| |||
1062 | 1062 | | |
1063 | 1063 | | |
1064 | 1064 | | |
1065 | | - | |
| 1065 | + | |
1066 | 1066 | | |
1067 | 1067 | | |
1068 | 1068 | | |
| |||
0 commit comments