Skip to content

Commit c0d459c

Browse files
Merge pull request #245 from CodeForPhilly/chore/close-slug-refs-2.9
chore(plans): close out slug-references and gitsheets-2.9
2 parents 4ec86d2 + 65e6a18 commit c0d459c

3 files changed

Lines changed: 15 additions & 8 deletions

File tree

‎plans/gitsheets-2.9.md‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
---
2-
status: in-progress
2+
status: done
33
depends: [slug-references]
44
specs:
55
- specs/behaviors/storage.md
66
- specs/behaviors/slug-handles.md
7+
pr: 243
78
---
89

910
# Plan: adopt gitsheets 2.9
@@ -48,7 +49,7 @@ follow-up; #307 import-merge runbook.
4849
(person, project, event, cascade) still show attachments moved;
4950
buzz regenerateSlug keeps its image (test)
5051
- [x] `type-check` + `lint` + full suite green
51-
- [ ] Sandbox and production boot on the release
52+
- [x] Sandbox and production boot on the release
5253

5354
## Notes
5455

@@ -62,4 +63,6 @@ follow-up; #307 import-merge runbook.
6263
- The musl core-napi build is in the lockfile. Loading it in the Alpine
6364
image is verified when the release image runs on sandbox.
6465

66+
- Shipped in v0.9.0; the Alpine image loads core-napi 0.7.0 (sandbox and production booted, 0 restarts).
67+
6568
## Follow-ups

‎plans/slug-references.md‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
status: in-progress
2+
status: done
33
depends: [sheet-contracts]
44
specs:
55
- specs/principles.md
@@ -92,7 +92,7 @@ Out:
9292
- [x] Migration: idempotent; refuses to write if any reference doesn't
9393
resolve; `contracts verify` passes after it on every branch
9494
- [x] `type-check` + `lint` + full suite green
95-
- [ ] `published` migrated and adopted in lockstep with the release;
95+
- [x] `published` migrated and adopted in lockstep with the release;
9696
sandbox and production boot
9797

9898
## Risks / unknowns
@@ -117,8 +117,8 @@ Out:
117117
that no longer exist (it protected no one); it also deletes the pruned
118118
person's RSVPs. Account-claim merge re-points the requester's RSVPs.
119119
scrub-data pseudonymizes every person-slug reference consistently.
120-
- Remaining before `done`: migrate and adopt on `published` in lockstep
121-
with the release, then boot sandbox and production.
120+
121+
- `published` migrated (1,450 records) and adopted v2 in lockstep with v0.9.0 (`13ac63b`); sandbox and production booted, and memberships resolve both ways.
122122

123123
## Follow-ups
124124

‎plans/slug-rename-attachments.md‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
status: in-progress
2+
status: done
33
depends: [slug-history-config]
44
specs:
55
- specs/behaviors/slug-handles.md
@@ -51,7 +51,7 @@ later commit once the move API ships.
5151
- [x] Test: rename a person with an avatar; the avatar is served at the new
5252
key and `avatarKey` matches
5353
- [x] Test: rename a project; no attachments are orphaned
54-
- [ ] (after upstream) no delete-then-upsert left in the rename paths
54+
- [x] (after upstream) no delete-then-upsert left in the rename paths
5555
- [x] `type-check` + `lint` + full api suite green
5656

5757
## Risks / unknowns
@@ -65,4 +65,8 @@ later commit once the move API ships.
6565
`featuredImageKey` are rewritten. What's left is swapping this for a native
6666
gitsheets move once one exists (see `awaits`).
6767

68+
- Finished by [`gitsheets-2.9`](gitsheets-2.9.md) (PR #243): gitsheets#302
69+
shipped native rename-on-upsert that moves attachments, and every rename
70+
path now uses it via `upsertMoved`. The take/restore interim is removed.
71+
6872
## Follow-ups

0 commit comments

Comments
 (0)