Skip to content

Commit 0e32245

Browse files
docs(plans): close out chat-links-full-navigation and slack-header-link
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TGqwPjt3v4eMfiHpPmCKnR
1 parent 34d617c commit 0e32245

2 files changed

Lines changed: 29 additions & 6 deletions

File tree

‎plans/chat-links-full-navigation.md‎

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
---
2-
status: in-progress
2+
status: done
33
depends: [chat-redirect]
44
specs:
55
- specs/screens/chat.md
66
issues: [230]
7+
pr: 233
78
---
89

910
# Plan: In-app links to /chat navigate to the server
@@ -36,10 +37,10 @@ a lint rule rejects router links whose literal target starts with `/chat`,
3637

3738
## Validation
3839

39-
- [ ] `npm run type-check && npm run lint && npm test` clean.
40-
- [ ] The rule flags the five links before the fix (checked by running
40+
- [x] `npm run type-check && npm run lint && npm test` clean.
41+
- [x] The rule flags the five links before the fix (checked by running
4142
lint against the unfixed tree).
42-
- [ ] In the built app, clicking footer "Slack" leaves the SPA for the
43+
- [x] In the built app, clicking footer "Slack" leaves the SPA for the
4344
Slack SSO start URL instead of rendering the 404 page.
4445

4546
## Risks / unknowns
@@ -49,4 +50,14 @@ a lint rule rejects router links whose literal target starts with `/chat`,
4950

5051
## Notes
5152

53+
- Five links, not the three the issue named: the project page's "Chat
54+
Channel" button and the project card's "Chat" had the same bug.
55+
- Verified on the devbox build of develop at 0911423: clicking the footer
56+
"Slack" left the SPA through Slack's SSO start to the production IdP's
57+
sign-in (Slack's IdP is codeforphilly.org) instead of the 404 page.
58+
- The Vite dev server doesn't proxy `/chat`, so this can't be checked
59+
under `npm run dev`; it needs the built app.
60+
5261
## Follow-ups
62+
63+
- **None.**

‎plans/slack-header-link.md‎

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
---
2-
status: in-progress
2+
status: done
33
depends: [chat-links-full-navigation]
44
specs:
55
- specs/behaviors/app-shell.md
66
issues: [231]
7+
pr: 235
78
---
89

910
# Plan: Slack in the header
@@ -43,7 +44,7 @@ content links); changing `/chat` itself.
4344
- [x] At 1024px and 1280px the desktop header keeps every content link on
4445
one line with Slack and GitHub showing; at 768px the mobile header shows.
4546
- [x] At 390px the sheet lists Slack before GitHub.
46-
- [ ] Clicking the header icon opens the Slack SSO start in a new tab.
47+
- [x] Clicking the header icon opens the Slack SSO start in a new tab.
4748

4849
## Risks / unknowns
4950

@@ -52,4 +53,15 @@ content links); changing `/chat` itself.
5253

5354
## Notes
5455

56+
- The 768px overflow predates this change: develop already wrapped "Help
57+
Wanted" and pushed Volunteer off the edge there, most likely since
58+
Events joined the content cluster. Moving the breakpoint fixed that too.
59+
- The header icon is the same `/chat` anchor as the footer link verified
60+
in [chat-links-full-navigation](chat-links-full-navigation.md), plus
61+
`target="_blank"`; checked by markup rather than a second click-through.
62+
- Chose an icon beside GitHub over a "Chat" text item in the content
63+
cluster.
64+
5565
## Follow-ups
66+
67+
- **None.**

0 commit comments

Comments
 (0)