Preserve code-only driver settings on DbConnection/DbDataSource paths #122
alex-clickhouseAnnotations
10 warnings
|
.NET 10.0:
src/EFCore.ClickHouse/Query/Internal/ClickHouseSqlNullabilityProcessor.cs#L168
Change return type of method 'VisitJsonPathExpression' from 'Microsoft.EntityFrameworkCore.Query.SqlExpressions.SqlExpression' to 'ClickHouse.EntityFrameworkCore.Query.Expressions.Internal.ClickHouseJsonPathExpression' for improved performance (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1859)
|
|
.NET 10.0:
src/EFCore.ClickHouse/Migrations/Internal/ClickHouseHistoryRepository.cs#L16
The behavior of 'Convert.ToBoolean(object)' could vary based on the current user's locale settings. Replace this call in 'ClickHouseHistoryRepository.InterpretExistsResult(object)' with a call to 'Convert.ToBoolean(object, IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
.NET 10.0:
src/EFCore.ClickHouse/Migrations/Internal/ClickHouseMigrationDatabaseLock.cs#L19
Change ClickHouseMigrationDatabaseLock.DisposeAsync() to call GC.SuppressFinalize(object). This will prevent derived types that introduce a finalizer from needing to re-implement 'IDisposable' to call it. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1816)
|
|
.NET 10.0:
src/EFCore.ClickHouse/Migrations/Internal/ClickHouseMigrationDatabaseLock.cs#L17
Change ClickHouseMigrationDatabaseLock.Dispose() to call GC.SuppressFinalize(object). This will prevent derived types that introduce a finalizer from needing to re-implement 'IDisposable' to call it. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1816)
|
|
.NET 10.0:
src/EFCore.ClickHouse/Metadata/Conventions/ClickHouseConventionSetBuilder.cs#L38
Change type of parameter 'conventions' from 'System.Collections.Generic.IList<Microsoft.EntityFrameworkCore.Metadata.Conventions.IEntityTypeBaseTypeChangedConvention>' to 'System.Collections.Generic.List<Microsoft.EntityFrameworkCore.Metadata.Conventions.IEntityTypeBaseTypeChangedConvention>' for improved performance (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1859)
|
|
.NET 10.0:
src/EFCore.ClickHouse/Migrations/Internal/ClickHouseMigrationsAnnotationProvider.cs#L10
Microsoft.EntityFrameworkCore.Migrations.MigrationsAnnotationProviderDependencies is an internal API that supports the Entity Framework Core infrastructure and not subject to the same compatibility standards as public APIs. It may be changed or removed without notice in any release.
|
|
.NET 10.0:
src/EFCore.ClickHouse/Metadata/Internal/ClickHouseAnnotationProvider.cs#L53
Do not use Enumerable methods on indexable collections. Instead use the collection directly. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1826)
|
|
.NET 10.0:
src/EFCore.ClickHouse/Infrastructure/Internal/ClickHouseModelValidator.cs#L73
For improved performance, use the LoggerMessage delegates instead of calling 'LoggerExtensions.Log(ILogger, LogLevel, string?, params object?[])' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1848)
|
|
.NET 10.0:
src/EFCore.ClickHouse/Infrastructure/Internal/ClickHouseModelValidator.cs#L40
For improved performance, use the LoggerMessage delegates instead of calling 'LoggerExtensions.Log(ILogger, LogLevel, string?, params object?[])' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1848)
|
|
.NET 10.0:
src/EFCore.ClickHouse/Infrastructure/Internal/ClickHouseOptionsExtension.cs#L58
In member RelationalOptionsExtension ClickHouseOptionsExtension.WithConnection(DbConnection? connection, bool contextOwnsConnection = false), change parameter name contextOwnsConnection to owned in order to match the identifier as it has been declared in RelationalOptionsExtension RelationalOptionsExtension.WithConnection(DbConnection? connection, bool owned) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1725)
|