Imports Support#95
Open
LesterEvSe wants to merge 3 commits into
Open
Conversation
LesterEvSe
force-pushed
the
feature/imports-v2
branch
from
667340e to
4084ed0
Compare
LesterEvSe
force-pushed
the
feature/imports-v2
branch
from
4084ed0 to
3cab2bd
Compare
Arvolear
reviewed
Jun 12, 2026
Arvolear
reviewed
Jun 12, 2026
Arvolear
reviewed
Jun 12, 2026
Arvolear
reviewed
Jun 12, 2026
Arvolear
reviewed
Jun 12, 2026
LesterEvSe
force-pushed
the
feature/imports-v2
branch
from
3cab2bd to
e509d10
Compare
Arvolear
reviewed
Jun 15, 2026
Arvolear
reviewed
Jun 15, 2026
Arvolear
reviewed
Jun 15, 2026
Arvolear
reviewed
Jun 15, 2026
Arvolear
reviewed
Jun 15, 2026
Arvolear
reviewed
Jun 15, 2026
Arvolear
reviewed
Jun 15, 2026
Arvolear
reviewed
Jun 15, 2026
Comment on lines
+109
to
+110
| let re = RE.get_or_init(|| Regex::new(r"(?m)^\s*(pub\s+)?fn\s+main\s*\(").unwrap()); | ||
| re.is_match(source) |
Member
There was a problem hiding this comment.
Suggested change
| let re = RE.get_or_init(|| Regex::new(r"(?m)^\s*(pub\s+)?fn\s+main\s*\(").unwrap()); | |
| re.is_match(source) | |
| let re = RE.get_or_init(|| Regex::new(r"(?m)^\s*(pub\s+)?fn\s+main\s*\(").unwrap()); | |
| re.is_match(source) |
Member
There was a problem hiding this comment.
What if the main function is commented out?
Collaborator
Author
There was a problem hiding this comment.
Good question. We could strip all comments with regex and then check for a main function. But we would still have a problem with strings in the future. For example "fn main(", or telling that a "/* */" inside a string isn't actually a comment. So I am considering doing it with the parse function from HL
Arvolear
reviewed
Jun 15, 2026
Arvolear
reviewed
Jun 15, 2026
Arvolear
reviewed
Jun 15, 2026
Arvolear
reviewed
Jun 15, 2026
Arvolear
reviewed
Jun 15, 2026
Arvolear
reviewed
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #69. Now that SimplicityHL natively supports flattening (PR #337) functionality, it made more sense to rewrite this implementation from scratch in a clean PR rather than trying to salvage and rebase the old one