From 3c83a9e1320bf2cbd12fcd12776fdeed54560b81 Mon Sep 17 00:00:00 2001 From: Victor Vazquez Date: Thu, 16 Jul 2026 20:22:22 +0000 Subject: [PATCH] ci: remove --no-optional from vscode dependency install esbuild ships its platform-specific binary (@esbuild/) as an optional dependency. Installing with 'npm ci --no-optional' drops that binary, causing the vscode ADO pipeline Test task to fail on all three OSes with '@esbuild/ could not be found'. Remove --no-optional from both the ADO job and the GitHub Actions workflow so the correct esbuild platform binary is installed. Fixes #9140 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: bfac0afb-0a7c-4406-93f8-ee4506b494e6 --- .github/workflows/vscode-ci.yml | 2 +- eng/pipelines/templates/jobs/vscode-build.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/vscode-ci.yml b/.github/workflows/vscode-ci.yml index e52fd336e8f..ed840acd432 100644 --- a/.github/workflows/vscode-ci.yml +++ b/.github/workflows/vscode-ci.yml @@ -63,7 +63,7 @@ jobs: - name: Install dependencies run: | - npm ci --no-optional + npm ci working-directory: ./ext/vscode - name: Test diff --git a/eng/pipelines/templates/jobs/vscode-build.yml b/eng/pipelines/templates/jobs/vscode-build.yml index 53654303a32..60b656dc12b 100644 --- a/eng/pipelines/templates/jobs/vscode-build.yml +++ b/eng/pipelines/templates/jobs/vscode-build.yml @@ -35,7 +35,7 @@ jobs: - pwsh: | npm i -g npm @vscode/vsce - npm ci --no-optional + npm ci workingDirectory: ext/vscode displayName: Install dependencies