{Compute} az vmss extension: Migrate command group to aaz-based implementation#33337
Open
william051200 wants to merge 11 commits into
Open
{Compute} az vmss extension: Migrate command group to aaz-based implementation#33337william051200 wants to merge 11 commits into
az vmss extension: Migrate command group to aaz-based implementation#33337william051200 wants to merge 11 commits into
Conversation
william051200
requested review from
NoriZC,
teresaritorto and
yanzhudd
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
Bot
added
Compute
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates the az vmss extension command group in the VM command module from azure-mgmt-compute SDK usage to AAZ-based implementations, aligning VMSS extension operations with the newer AAZ patterns already used elsewhere in command_modules/vm.
Changes:
- Reworked VMSS extension delete/show/list/set to use AAZ VMSS show + AAZ VMSS update flows (with snake_case conversion for update payloads).
- Switched
vmss extension upgradeto an AAZ-generated rolling upgrade command. - Updated command registration for
vmss extensionto remove the compute SDK command group binding and removed themin_apigate onupgrade.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
src/azure-cli/azure/cli/command_modules/vm/custom.py |
Migrates VMSS extension CRUD operations to AAZ; builds update payloads via convert_show_result_to_snake_case and invokes AAZ vmss Update. |
src/azure-cli/azure/cli/command_modules/vm/commands.py |
Updates vmss extension command group registration for AAZ migration and adjusts the upgrade registration. |
src/azure-cli/azure/cli/command_modules/vm/aaz/latest/vmss/extension/_rolling_upgrade.py |
Adds AAZ-generated implementation for VMSS extension rolling upgrade. |
src/azure-cli/azure/cli/command_modules/vm/aaz/latest/vmss/extension/__init__.py |
Exposes the new rolling upgrade command via package exports. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+5356
to
+5357
| x.get('type_properties_type', '').lower() != extension_name.lower() | ||
| or x.get('publisher').lower() != publisher.lower()] |
| @@ -5283,102 +5283,109 @@ def detach_disk_from_vmss(cmd, resource_group_name, vmss_name, lun, instance_id= | |||
|
|
|||
| # region VirtualMachineScaleSets Extensions | |||
| def delete_vmss_extension(cmd, resource_group_name, vmss_name, extension_name): | |||
| g.custom_command('set', 'set_vmss_extension', supports_no_wait=True) | ||
| g.custom_command('list', 'list_vmss_extensions') | ||
| g.custom_command('upgrade', 'upgrade_vmss_extension', min_api='2020-06-01', supports_no_wait=True) | ||
| g.custom_command('upgrade', 'upgrade_vmss_extension', supports_no_wait=True) |
Comment on lines
+410
to
413
| with self.command_group('vmss extension') as g: | ||
| g.custom_command('delete', 'delete_vmss_extension', supports_no_wait=True) | ||
| g.custom_show_command('show', 'get_vmss_extension') | ||
| g.custom_command('set', 'set_vmss_extension', supports_no_wait=True) |
Comment on lines
5351
to
+5358
| if extension_profile: | ||
| extensions = extension_profile.extensions | ||
| extensions = extension_profile.get('extensions') | ||
| if extensions: | ||
| extension_profile.extensions = [x for x in extensions if | ||
| x.type_properties_type.lower() != extension_name.lower() or x.publisher.lower() != publisher.lower()] # pylint: disable=line-too-long | ||
|
|
||
| if cmd.supported_api_version(min_api='2019-07-01', operation_group='virtual_machine_scale_sets'): | ||
| ext = VirtualMachineScaleSetExtension(name=extension_instance_name, | ||
| publisher=publisher, | ||
| type_properties_type=extension_name, | ||
| protected_settings=protected_settings, | ||
| type_handler_version=version, | ||
| settings=settings, | ||
| auto_upgrade_minor_version=(not no_auto_upgrade), | ||
| provision_after_extensions=provision_after_extensions, | ||
| enable_automatic_upgrade=enable_auto_upgrade) | ||
| else: | ||
| ext = VirtualMachineScaleSetExtension(name=extension_instance_name, | ||
| publisher=publisher, | ||
| type=extension_name, | ||
| protected_settings=protected_settings, | ||
| type_handler_version=version, | ||
| settings=settings, | ||
| auto_upgrade_minor_version=(not no_auto_upgrade), | ||
| provision_after_extensions=provision_after_extensions, | ||
| enable_automatic_upgrade=enable_auto_upgrade) | ||
| extension_profile['extensions'] = \ | ||
| [x for x in extensions if | ||
| x.get('type_properties_type', '').lower() != extension_name.lower() | ||
| or x.get('publisher').lower() != publisher.lower()] | ||
|
|
william051200
requested review from
DanielMicrosoft,
ReaNAiveD and
necusjz
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az vmss extension deleteaz vmss extension showaz vmss extension setaz vmss extension listaz vmss extension upgradeDescription
Migration from mgmt.compute to aaz-based
aaz Azure/aaz#1003
Testing Guide
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.