Repository navigation
Static source review cybersecurity-findings #50379
netanelcyber
started this conversation in
Show and tell
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
https://github.com/Automattic/jetpack(monorepo), commit3b9717e5e18063c5b7b4d4312da1bf8b27c61580(2026-07-09), plugin version16.0(projects/plugins/jetpack/jetpack.php).focused on SQLi, XSS, code-injection-class bugs (
eval, dynamicinclude/require,unserialize, dynamic class/functioninstantiation), command execution, and REST permission-callback gaps
across
projects/plugins/jetpack/(999 PHP files, excludingtests/).No live site was touched; nothing was executed.
(hackerone.com/automattic) covers Jetpack, per the same
SECURITY.mdreferenced in the WooCommerce review (same parent org/monorepo).
no confirmed match, but as with prior passes, Patchstack's plugin page
couldn't be fetched from this environment (blocked), so treat this as
inconclusive, not a clean bill of health.
[Low-Medium] Unsafe deserialization of a remote HTTP response body (CWE-502)
json-endpoints/jetpack/class.jetpack-json-api-themes-install-endpoint.php:150-179(
validate_themes()), reached viaPOST /sites/%s/themes/%s/install.-wpcomtheme, this endpoint calls the legacy, PHP-serialization-based
api.wordpress.org/themes/info/1.0/endpoint (WordPress core itselfmoved its own theme/plugin update checks to the JSON
1.1/1.2endpoints years ago specifically to get away from unserializing remote
responses — the
@todocomment in this file shows the Jetpack team isalready aware this specific call hasn't been migrated). The raw HTTP
response body is then passed straight into
unserialize()with noallowed_classesrestriction.install_themescapability (admin-level) toreach the endpoint at all — this isn't reachable by an anonymous or
low-privileged user. The remote host is hardcoded to the legitimate
api.wordpress.org, so this is not attacker-controlled SSRF; exploitingthe deserialization itself would require the response actually returned
by (or something able to impersonate)
api.wordpress.org's legacy1.0endpoint to contain a malicious serialized payload — i.e., a supply-chain
or network-path compromise on that specific dependency, not a
directly-attacker-suppliable input in the ordinary sense.
unserialize is potentially exploitable into RCE given a suitable POP
gadget chain among classes loaded by WordPress core, Jetpack, or any
other active plugin/theme — same vulnerability class flagged in the
Yoast SEO and WooCommerce reviews. Realistic likelihood is low (requires
compromising or MITM'ing a real wordpress.org API response over HTTPS),
but the fix is simple and the code path is already flagged by its own
authors as legacy/overdue for migration.
api.wordpress.org/themes/info/1.1/(JSON, as the existing
@todocomment already says to do), or at minimum(b) change to
unserialize( $response['body'], array( 'allowed_classes' => false ) )as a low-effort interim mitigation.
Checked, not found (negative results)
unserialize()/maybe_unserialize()hits inprojects/plugins/jetpack/(outsidetests/) operate on Jetpack's owninternally-generated data: post meta the plugin itself wrote
(
sal/class.json-api-post-base.php,functions.global.php), aninternal endpoint-registry cache key built from
serialize()onhardcoded route definitions (
class.json-api.php:484,sal/class.json-api-links.php:418— confirmed not request-influenced),and a VideoPress player's own cached object
(
modules/videopress/class.videopress-player.php). No external-inputwrite path found into any of these.
eval()hits are exclusively intests/php/(unit-test stubs for classisolation) — not production/request-reachable code.
proc_open()hit is intools/build-asset-cdn-json.php, abuild-time script, not runtime plugin code reachable via a web request.
system()/exec()/shell_exec()/passthru()/popen()inproduction code.
$wpdb->query()/get_*()call with$_GET/$_POST/$_REQUESTinterpolated directly into SQL.
echo $_GET/$_POST/$_REQUEST/$_COOKIE[...]without escaping.permission_callback => '__return_true'REST routes found(
wpcom-endpoints/class-wpcom-rest-api-v2-endpoint-ai.php's/jetpack-search/ai/searchand/jetpack-search/ai/rank,class-wpcom-rest-api-v2-endpoint-mailchimp.php,hello.php,business-hours.php,class-wpcom-rest-api-v2-endpoint-instagram-gallery.php)are all public, read-oriented, site-facing features (on-site AI search
for visitors, a Mailchimp signup form, a business-hours widget, an
Instagram embed) — intentionally public by design, same category as
WooCommerce's Store API. Not a finding.
Not covered this pass (scope limit)
999 files (and the plugin is one of ~19 in this monorepo) is too large for
a full pass. Not examined in depth: Jetpack Sync (the subsystem that
mirrors site data to WordPress.com — a historically sensitive area for
this plugin), the XML-RPC/connection-signature verification code itself
(
Automattic\Jetpack\Connection), and the other 18 plugins in themonorepo (Backup, Boost, Protect, Search, Social, VaultPress, etc.), which
are separate WordPress.org listings in their own right.
All reactions