Skip to content

(WIP) feat: migrate integration tests#44

Draft
lima-limon-inc wants to merge 10 commits into0xMiden:mainfrom
lambdaclass:fabrizioorsi/i27-mockchain-api
Draft

(WIP) feat: migrate integration tests#44
lima-limon-inc wants to merge 10 commits into0xMiden:mainfrom
lambdaclass:fabrizioorsi/i27-mockchain-api

Conversation

@lima-limon-inc
Copy link
Copy Markdown
Contributor

Closes #27

Migrate the test suite to the new Mockchain API.

Sidenote: this PR has the same changes present in #39, only rebased to the latest changes in main which were added in #37

@Keinberger
Copy link
Copy Markdown
Collaborator

Hey @lima-limon-inc what's the status on this one? PR #37 landed Apr 23 and unblocks the migration here, but #44 hasn't moved since you opened it. Are you actively working on it, blocked, or would you prefer to hand it off?
Looking at the diff, a few things stood out that may have come from the rebase rather than being intentional:

  • duplicate use blocks in integration/tests/counter_test.rs and integration/src/bin/increment_count.rs (won't compile)
  • contracts/*/Cargo.lock files downgrade miden from 0.12 to 0.11 (main is on 0.12)
  • several skills under .claude/skills/ look reverted to pre-Migrate to the client v0.14 #37 versions
    @greenhat flagging since this is your area and Migrate to the client v0.14 #37 was the dependency. Worth a look from your end too.

@lima-limon-inc
Copy link
Copy Markdown
Contributor Author

Hey @lima-limon-inc what's the status on this one?

Hey there @PhilippGackstatter. Thanks for the ping 😊 . I was tackling this, however, an issue came up on the https://github.com/0xMiden/midenup repository and I am currently working on 0xMiden/midenup#196. That midenup PR is pretty far along, so it should be done by tomorrow.

My plan is to finish this PR right afterwards. I'll ping this thread as soon as I get on with it if that's okay.

Looking at the diff, a few things stood out that may have come from the rebase rather than being intentional:
(...)

Yes indeed. If I remember correctly, the bulk of the API migration was tackled when I first started this PR (before #37) got merged and I did rebase it as soon as #44 got merged; however, like you pointed out, some things got messed up during the rebase. At this point, I think the best course of action would be revert the rebase and rebase it against the latest changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate the integration tests to the new mockchain API

3 participants