(WIP) feat: migrate integration tests#44
(WIP) feat: migrate integration tests#44lima-limon-inc wants to merge 10 commits into0xMiden:mainfrom
Conversation
…:Felt` and remove `miden-core` dependency
next branch commit
|
Hey @lima-limon-inc what's the status on this one? PR #37 landed Apr 23 and unblocks the migration here, but #44 hasn't moved since you opened it. Are you actively working on it, blocked, or would you prefer to hand it off?
|
Hey there @PhilippGackstatter. Thanks for the ping 😊 . I was tackling this, however, an issue came up on the https://github.com/0xMiden/midenup repository and I am currently working on 0xMiden/midenup#196. That midenup PR is pretty far along, so it should be done by tomorrow. My plan is to finish this PR right afterwards. I'll ping this thread as soon as I get on with it if that's okay.
Yes indeed. If I remember correctly, the bulk of the API migration was tackled when I first started this PR (before #37) got merged and I did rebase it as soon as #44 got merged; however, like you pointed out, some things got messed up during the rebase. At this point, I think the best course of action would be revert the rebase and rebase it against the latest changes. |
Closes #27
Migrate the test suite to the new Mockchain API.
Sidenote: this PR has the same changes present in #39, only rebased to the latest changes in
mainwhich were added in #37